From: Michael Prokop <mika@grml.org>
Date: Fri, 19 May 2017 12:25:11 +0000 (+0200)
Subject: Drop config_stats
X-Git-Tag: v0.15.6~1
X-Git-Url: http://git.grml.org/?p=grml-autoconfig.git;a=commitdiff_plain;h=7138a24fbceb19f67a557f29593e3cc7d3e6448d

Drop config_stats

The stats feature was integrated to collect some basic
information about usage of Grml. While we anonymise
the data we also lack the according information *why*
things are used in a way they are used (e.g. since
we cut of any arguments to bootoptions we don't
know the actual settings for e.g. vga=xxx).

What we learned from the stats is that grml32 is still
in usage way more often than expected, though a leading
majority of the systems support 64bit, so it's unclear
why those users still use the 32bit version.

While we thought it was a good idea back then we think
different nowadays and users of Grml don't expect such
a behavior as default. So don't make it even opt-in but
just drop it overall.
---

diff --git a/autoconfig b/autoconfig
index c204001..345f637 100644
--- a/autoconfig
+++ b/autoconfig
@@ -77,7 +77,6 @@ CONFIG_PASSWD='yes'           # set password via bootparam passwd
 CONFIG_SCRIPTS='yes'          # execute scripts from the scripts option
 CONFIG_SECUREBOOT='yes'       # display information about secure boot
 CONFIG_SERVICES='yes'         # check for services to run, provided via bootparam
-CONFIG_STATS='yes'            # Report stats to stats server
 CONFIG_SSH='yes'              # check for bootparam ssh
 CONFIG_SWRAID='yes'           # check for software raid devices [only in live-mode]
 CONFIG_TESTCD='yes'           # CD checker
diff --git a/autoconfig.functions b/autoconfig.functions
index ccf12d6..8a534e2 100755
--- a/autoconfig.functions
+++ b/autoconfig.functions
@@ -1331,35 +1331,6 @@ config_netscript() {
 }
 # }}}
 
-# {{{ stats
-config_stats() {
- if ! checkbootparam 'nostats' ; then
-   BASE_URL="http://stats.grml.org/report/"
-   ACTION_NAME=Boot
-
-   HOST_ID=$(cat /proc/sys/kernel/random/boot_id)
-
-   grep -q " lm " /proc/cpuinfo && HAS_64BIT="1" || HAS_64BIT="0"
-   DATE_STRING=$(date +'h=%H&m=%M&s=%S')
-   [ -e /etc/grml_version ] && VERSION=$(cat /etc/grml_version) || \
-     VERSION=$(lsb_release -d | awk -F: '{gsub(/^[ \t]+/, "", $2); print $2}')
-
-   PARAMS="$( echo "$CMDLINE" | sed -e 's/=[^ ]*/=x/g' | tr " " "\n"|sort|tr "\n" " " )"
-
-   echo "$CMDLINE" | grep -q -e "fetch" -e "nfsroot" && BOOT="remote"
-   [ -z "$BOOT" ] && BOOT="local"
-
-   ADDITIONAL_PARAMS=""
-   ( [ -n "$COLUMNS" ] && [ -n "$LINES" ] ) && \
-     ADDITIONAL_PARAMS="$ADDITIONAL_PARAMS&res=$((COLUMNS * 8))x$((LINES * 16))"
-
-   URI='$BASE_URL?action=${ACTION_NAME}\&$DATE_STRING\&unique_id=${HOST_ID}\&support_64bit=$HAS_64BIT\&version=$VERSION\&bootup=$BOOT\&params=$PARAMS$ADDITIONAL_PARAMS'
-
-   get_remote_file "$URI" "/dev/null"  >/dev/null 2>&1 &!
- fi
-}
-# }}}
-
 # {{{ start X window system via grml-x
 config_x_startup(){
 
diff --git a/grml-autoconfig b/grml-autoconfig
index 47d0c7e..08c5edd 100755
--- a/grml-autoconfig
+++ b/grml-autoconfig
@@ -147,8 +147,6 @@ checkvalue $CONFIG_NETCONFIG && config_netconfig
 
 checkvalue $CONFIG_NETSCRIPT && config_netscript
 
-checkvalue $CONFIG_STATS && config_stats
-
 checkvalue $CONFIG_CONSOLE && config_console
 
 checkvalue $CONFIG_VIRTUALBOX_SHARED_FOLDERS && config_virtualbox_shared_folders