From bc8e3d7ffa255f345891e97c52174f48eef58c52 Mon Sep 17 00:00:00 2001 From: Michael Prokop Date: Mon, 28 Sep 2009 21:00:46 +0200 Subject: [PATCH] config_finddcsdir: some minor message display improvements --- autoconfig.functions | 22 ++++++++++++++-------- debian/changelog | 8 ++++++++ 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/autoconfig.functions b/autoconfig.functions index 53a8774..acf2def 100755 --- a/autoconfig.functions +++ b/autoconfig.functions @@ -1958,7 +1958,7 @@ else if checkbootparam 'myconfig' ; then DCSDEVICE="$(getbootparam 'myconfig' 2>>$DEBUG)" if [ -z "$DCSDEVICE" ]; then - einfo "No device for bootoption myconfig provided." ; eend 1 + eerror "Error: No device for bootoption myconfig provided." ; eend 1 fi # [ -z "$DCSDEVICE" ] elif checkvalue $CONFIG_MYCONFIG; then # checkbootparam myconfig einfo "Searching for device(s) labeled with GRMLCFG. (Disable this via boot option: noautoconfig)" ; eend 0 @@ -1971,30 +1971,36 @@ else fi fi DCSDEVICE=$(blkid -t LABEL=GRMLCFG | head -1 | awk -F: '{print $1}') + eoutdent fi - if [ -n "$DCSDEVICE" ]; then + + # if not specified/present then assume default: + if [ -z "$DCSDEVICE" ]; then + DCSDIR="/live/image" + else + eindent einfo "debs, config, scripts are read from $DCSDEVICE." ; eend 0 DCSDIR="$(< /proc/mounts awk -v DCSDEV=$DCSDEVICE '{if ($1 == DCSDEV) { print $2 }}')" if [ -n "$DCSDIR" ]; then - einfo "$DCSDEVICE already mounted on $DCSDIR"; eend 0 + ewarn "$DCSDEVICE already mounted on $DCSDIR"; eend 0 else [ -d /mnt/grml ] || mkdir /mnt/grml umount /mnt/grml 1>>$DEBUG 2>&1 # make sure it is not mounted mount -o ro -t auto $DCSDEVICE /mnt/grml ; RC="$?" if [[ $RC == 0 ]]; then einfo "Successfully mounted $DCSDEVICE to /mnt/grml (readonly)." ; eend 0 - eindent + else + eerror "Error: mounting $DCSDEVICE to /mnt/grml (readonly) failed." ; eend 1 fi DCSDIR="/mnt/grml" fi - else - DCSDIR="/live/image" + eoutdent fi fi fi -if [ -n "$DCSDIR" ]; then - einfo "Debs, config, scripts will be read from $DCSDIR." ; eend 0 +if [ -n "$DCSDIR" -a "$DCSDIR" != "/live/image" ] ; then + einfo "Debs, config, scripts (if present) will be read from $DCSDIR." ; eend 0 elif checkbootparam 'debs' || checkbootparam 'config' || checkbootparam 'scripts'; then einfo "Debs, config, scripts will be read from the live image directly." ; eend 0 fi diff --git a/debian/changelog b/debian/changelog index 0158d8b..49677e7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +grml-autoconfig (0.8.32) unstable; urgency=low + + * config_finddcsdir: some minor message display improvements + (fix indention levels, display $DCSDIR only if non-default) + * unicode_start command: do not redirect stderr to debug file + + -- Michael Prokop Mon, 28 Sep 2009 20:59:57 +0200 + grml-autoconfig (0.8.31) unstable; urgency=low [ Ulrich Dangel ] -- 2.1.4