From af65087851ed8d2f74bd025b5862f5222884da97 Mon Sep 17 00:00:00 2001 From: Frank Terbeck Date: Sat, 30 Dec 2017 11:11:24 +0100 Subject: [PATCH] Partly revert c0a2a4d again As it turns out, zsh has defaults on HISTSIZE and SAVEHIST. I have lost track off zsh defaults a long time ago. This is a reason not to do this at all. HISTSIZE's default is 30, SAVEHIST's default is 0. And the latter is a big problem: No history will be saved anymore. If someone wants different values for these two parameters, they can set them in .zshrc.local. I am NOT working around this by comparing the actual value to zsh's defaults. The combined diff of c0a2a4d and this commit looks like this: [snip] --- a/etc/zsh/zshrc +++ b/etc/zsh/zshrc @@ -1582,7 +1582,7 @@ function command_not_found_handler () { # history #v# -HISTFILE=${ZDOTDIR:-${HOME}}/.zsh_history +HISTFILE=${HISTFILE:-${ZDOTDIR:-${HOME}}/.zsh_history} isgrmlcd && HISTSIZE=500 || HISTSIZE=5000 isgrmlcd && SAVEHIST=1000 || SAVEHIST=10000 # useful for setopt append_history [snap] Closes: Github bugreport #64 --- etc/zsh/zshrc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/etc/zsh/zshrc b/etc/zsh/zshrc index c64a1f8..51e6c75 100644 --- a/etc/zsh/zshrc +++ b/etc/zsh/zshrc @@ -1583,8 +1583,8 @@ function command_not_found_handler () { #v# HISTFILE=${HISTFILE:-${ZDOTDIR:-${HOME}}/.zsh_history} -isgrmlcd && HISTSIZE=500 || HISTSIZE=${HISTSIZE:-5000} -isgrmlcd && SAVEHIST=1000 || SAVEHIST=${SAVEHIST:-10000} # useful for setopt append_history +isgrmlcd && HISTSIZE=500 || HISTSIZE=5000 +isgrmlcd && SAVEHIST=1000 || SAVEHIST=10000 # useful for setopt append_history # dirstack handling -- 2.1.4