From: Evgeni Golov <evgeni@grml.org>
Date: Fri, 16 Oct 2015 15:08:29 +0000 (+0200)
Subject: notifyd: call aplay using subprocess.Popen + replace os.system with subprocess.call
X-Git-Tag: v2.7.2~2
X-Git-Url: http://git.grml.org/?p=grml-scripts.git;a=commitdiff_plain;h=ac55b37459c0b117a8a609d6e6d342424187402f

notifyd: call aplay using subprocess.Popen + replace os.system with subprocess.call

Closes #2
---

diff --git a/usr_bin/notifyd.py b/usr_bin/notifyd.py
index cf94ee6..28d985c 100755
--- a/usr_bin/notifyd.py
+++ b/usr_bin/notifyd.py
@@ -47,6 +47,7 @@ import string
 import socket
 import logging
 import getopt
+import subprocess
 
 default_hostname = 'localhost'
 default_port = 1234
@@ -58,12 +59,13 @@ default_logfile = None
 
 def play(sound_file):
     def play_wrapper(msg):
-        os.system('/usr/bin/aplay "%s" 2> /dev/null &' % sound_file)
+        with open(os.devnull, 'w') as devnull:
+            subprocess.Popen(['/usr/bin/aplay', sound_file], stderr=devnull)
     return play_wrapper
 
 def execute(command):
     def command_wrapper(msg):
-        os.system(command % dict(msg = msg))
+        subprocess.call(command % dict(msg = msg))
     return command_wrapper
 
 def osd(msg):