X-Git-Url: http://git.grml.org/?p=grml2usb.git;a=blobdiff_plain;f=grml2usb;h=bef2dc2b54fe3923d4c72843f5b59ee635a99e25;hp=0c9ffc09a9f0125b16797b8ba2415f01c2ef74fa;hb=3dd2d8e4798bf2ffcb0219aa6ec522765c4f02ad;hpb=5276a2374013612a6ead6e9b1f18ea4f84105cec diff --git a/grml2usb b/grml2usb index 0c9ffc0..bef2dc2 100755 --- a/grml2usb +++ b/grml2usb @@ -170,7 +170,7 @@ def cleanup(): os.unlink(tmpfile) # ignore: RuntimeError: Set changed size during iteration except RuntimeError: - logging.debug('caught expection RuntimeError, ignoring') + logging.debug('caught exception RuntimeError, ignoring') def register_tmpfile(path): @@ -311,7 +311,7 @@ def search_file(filename, search_path='/bin' + os.pathsep + '/usr/bin', lst_retu def check_uid_root(): """Check for root permissions""" if not os.geteuid() == 0: - sys.exit("Error: please run this script with uid 0 (root).") + raise CriticalException("please run this script with uid 0 (root).") def check_boot_flag(device): @@ -540,7 +540,7 @@ def install_mbr(mbrtemplate, device, partition, ismirbsdmbr=True): if not os.path.isfile(mbrtemplate): logging.error('Error installing MBR (either try --syslinux-mbr or ' 'install missing file "%s"?)', mbrtemplate) - raise CriticalException("Error: %s can not be read.", mbrtemplate) + raise CriticalException("%s can not be read." % mbrtemplate) if partition is not None and ((partition < 0) or (partition > 3)): logging.warn("Cannot activate partition %d", partition) @@ -796,7 +796,7 @@ def copy_system_files(grml_flavour, iso_mount, target): squashfs = search_file(grml_flavour + '.squashfs', iso_mount) if squashfs is None: logging.error("error locating squashfs file") - raise CriticalException("Fatal: squashfs file not found" + raise CriticalException("squashfs file not found" ", please check that your iso is not corrupt") else: squashfs_target = target + '/live/' + grml_flavour + '/' @@ -1048,8 +1048,8 @@ def copy_bootloader_files(iso_mount, target, grml_flavour): if not source_dir: raise CriticalException( - "Fatal: file default.cfg could not be found." \ - "Note: this grml2usb version requires an ISO generated by grml-live >=0.9.24 ..." \ + "file default.cfg could not be found.\n" + "Note: this grml2usb version requires an ISO generated by grml-live >=0.9.24 ...\n" " ... either use grml releases >=2009.10 or switch to an older grml2usb version.") if not os.path.exists(iso_mount + '/boot/grub/footer.cfg'): @@ -1488,8 +1488,8 @@ def install(image, device): try: remove_mountpoint(iso_mountpoint) except CriticalException, error: - logging.critical("Fatal: %s", error) cleanup() + raise def install_grml(mountpoint, device): @@ -1511,7 +1511,6 @@ def install_grml(mountpoint, device): check_boot_flag(device) mount(device, device_mountpoint, ['-o', 'utf8,iocharset=iso8859-1']) except VerifyException, error: - logging.critical("Fatal: %s", error) raise except CriticalException, error: mount(device, device_mountpoint, "") @@ -1538,8 +1537,8 @@ def remove_mountpoint(mountpoint): os.rmdir(mountpoint) unregister_tmpfile(mountpoint) except CriticalException, error: - logging.critical("Fatal: %s", error) cleanup() + raise def handle_mbr(device): @@ -1645,14 +1644,13 @@ def handle_logging(): if options.verbose and options.quiet: parser.error("please use either verbose (--verbose) or quiet (--quiet) option") + FORMAT = "%(message)s" if options.verbose: - FORMAT = "Debug: %(asctime)-15s %(message)s" + FORMAT = "%(asctime)-15s %(message)s" logging.basicConfig(level=logging.DEBUG, format=FORMAT) elif options.quiet: - FORMAT = "Critical: %(message)s" logging.basicConfig(level=logging.CRITICAL, format=FORMAT) else: - FORMAT = "%(message)s" logging.basicConfig(level=logging.INFO, format=FORMAT) @@ -1676,8 +1674,7 @@ def check_options(opts): @opts option dict from OptionParser """ if opts.grubmbr and not opts.grub: - logging.critical("Error: --grub-mbr requires --grub option.") - sys.exit(1) + raise CriticalException("--grub-mbr requires --grub option.") def check_programs():