X-Git-Url: http://git.grml.org/?p=grml2usb.git;a=blobdiff_plain;f=grml2usb;h=d5a86753a2f58eeb219045ea56f670237a484bb0;hp=6d2a75480e53035e1b78da834427e67431d516ad;hb=7b409afb354c914dfb74119136d4d36e43011508;hpb=a17807b16408dc049e90fcf176dd5e0a0e9abd91 diff --git a/grml2usb b/grml2usb index 6d2a754..d5a8675 100755 --- a/grml2usb +++ b/grml2usb @@ -170,7 +170,7 @@ def cleanup(): os.unlink(tmpfile) # ignore: RuntimeError: Set changed size during iteration except RuntimeError: - logging.debug('caught expection RuntimeError, ignoring') + logging.debug('caught exception RuntimeError, ignoring') def register_tmpfile(path): @@ -538,11 +538,12 @@ def install_mbr(mbrtemplate, device, partition, ismirbsdmbr=True): logging.info("Installing default MBR") if not os.path.isfile(mbrtemplate): - logging.critical("Error: %s can not be read.", mbrtemplate) - raise CriticalException("Error installing MBR (either try --syslinux-mbr or install missing file \"%s\"?)" % mbrtemplate) + logging.error('Error installing MBR (either try --syslinux-mbr or ' + 'install missing file "%s"?)', mbrtemplate) + raise CriticalException("Error: %s can not be read.", mbrtemplate) if partition is not None and ((partition < 0) or (partition > 3)): - logging.warn("Cannot activate partition %d" % partition) + logging.warn("Cannot activate partition %d", partition) partition = None if ismirbsdmbr: @@ -794,9 +795,9 @@ def copy_system_files(grml_flavour, iso_mount, target): squashfs = search_file(grml_flavour + '.squashfs', iso_mount) if squashfs is None: - logging.critical("Fatal: squashfs file not found" - ", please check that your iso is not corrupt") - raise CriticalException("error locating squashfs file") + logging.error("error locating squashfs file") + raise CriticalException("Fatal: squashfs file not found" + ", please check that your iso is not corrupt") else: squashfs_target = target + '/live/' + grml_flavour + '/' execute(mkdir, squashfs_target) @@ -807,8 +808,8 @@ def copy_system_files(grml_flavour, iso_mount, target): if filesystem_module: break if filesystem_module is None: - logging.critical("Fatal: filesystem.module not found") - raise CriticalException("error locating filesystem.module file") + logging.error("error locating filesystem.module file") + raise CriticalException("filesystem.module not found") else: exec_rsync(filesystem_module, squashfs_target + 'filesystem.module') @@ -822,8 +823,8 @@ def copy_system_files(grml_flavour, iso_mount, target): kernel = search_file('linux26', iso_mount) if kernel is None: - logging.critical("Fatal: kernel not found") - raise CriticalException("error locating kernel file") + logging.error("error locating kernel file") + raise CriticalException("Kernel not found") source = os.path.dirname(kernel) + '/' dest = target + '/' + os.path.dirname(kernel).replace(iso_mount, '') + '/' @@ -1046,10 +1047,10 @@ def copy_bootloader_files(iso_mount, target, grml_flavour): (source_dir, defaults_file) = get_defaults_file(iso_mount, grml_flavour, "grml.cfg") if not source_dir: - logging.critical("Fatal: file default.cfg could not be found.") - logging.critical("Note: this grml2usb version requires an ISO generated by grml-live >=0.9.24 ...") - logging.critical(" ... either use grml releases >=2009.10 or switch to an older grml2usb version.") - raise + raise CriticalException( + "Fatal: file default.cfg could not be found." \ + "Note: this grml2usb version requires an ISO generated by grml-live >=0.9.24 ..." \ + " ... either use grml releases >=2009.10 or switch to an older grml2usb version.") if not os.path.exists(iso_mount + '/boot/grub/footer.cfg'): logging.warning("Warning: Grml releases older than 2011.12 support only one flavour in grub.") @@ -1163,7 +1164,6 @@ def identify_grml_flavour(mountpath): except TypeError, e: raise except Exception, e: - logging.critical("Unexpected error: %s", e) raise finally: if tmpfile: @@ -1472,7 +1472,7 @@ def install(image, device): logging.info("Using %s as install base", image) else: logging.info("Using ISO %s", image) - iso_mountpoint = tempfile.mkdtemp(prefix="grml2usb", dir=options.tmpdir) + iso_mountpoint = tempfile.mkdtemp(prefix="grml2usb", dir=os.path.abspath(options.tmpdir)) register_tmpfile(iso_mountpoint) remove_image_mountpoint = True try: @@ -1514,11 +1514,7 @@ def install_grml(mountpoint, device): logging.critical("Fatal: %s", error) raise except CriticalException, error: - try: - mount(device, device_mountpoint, "") - except CriticalException, error: - logging.critical("Fatal: %s", error) - raise + mount(device, device_mountpoint, "") try: grml_flavours = identify_grml_flavour(mountpoint) for flavour in set(grml_flavours): @@ -1533,7 +1529,7 @@ def install_grml(mountpoint, device): def remove_mountpoint(mountpoint): - """remove a registred mountpoint + """remove a registered mountpoint """ try: @@ -1556,7 +1552,7 @@ def handle_mbr(device): return 0 mbr_device, partition_number = get_device_from_partition(device) - if not partition_number: + if partition_number is None: logging.warn("Could not detect partition number, not activating partition") # if we get e.g. /dev/loop1 as device we don't want to put the MBR @@ -1705,6 +1701,11 @@ def check_programs(): def load_loop(): """Runs modprobe loop and throws away it's output""" + if not which("modprobe"): + logging.critical("Fatal: modprobe not available, can not continue - sorry.") + logging.critical("Hint: is /sbin missing in PATH?") + sys.exit(1) + proc = subprocess.Popen(["modprobe", "loop"], stdout=subprocess.PIPE, stderr=subprocess.PIPE) proc.wait() @@ -1712,67 +1713,72 @@ def load_loop(): def main(): """Main function [make pylint happy :)]""" - if options.version: - print os.path.basename(sys.argv[0]) + " " + PROG_VERSION - sys.exit(0) + try: + if options.version: + print os.path.basename(sys.argv[0]) + " " + PROG_VERSION + sys.exit(0) - if len(args) < 2: - parser.error("invalid usage") + if len(args) < 2: + parser.error("invalid usage") - # log handling - handle_logging() + # log handling + handle_logging() - # make sure we have the appropriate permissions - check_uid_root() + # make sure we have the appropriate permissions + check_uid_root() - check_options(options) + check_options(options) - load_loop() + load_loop() - logging.info("Executing grml2usb version %s", PROG_VERSION) + logging.info("Executing grml2usb version %s", PROG_VERSION) - if options.dryrun: - logging.info("Running in simulation mode as requested via option dry-run.") + if options.dryrun: + logging.info("Running in simulation mode as requested via option dry-run.") - check_programs() + check_programs() - # specified arguments - device = os.path.realpath(args[len(args) - 1]) - isos = args[0:len(args) - 1] + # specified arguments + device = os.path.realpath(args[len(args) - 1]) + isos = args[0:len(args) - 1] - if not os.path.isdir(device): - if device[-1:].isdigit(): - if int(device[-1:]) > 4 or device[-2:].isdigit(): - logging.critical("Fatal: installation on partition number >4 not supported. (BIOS won't support it.)") - sys.exit(1) + if not os.path.isdir(device): + if device[-1:].isdigit(): + if int(device[-1:]) > 4 or device[-2:].isdigit(): + logging.critical("Fatal: installation on partition number >4 not supported. (BIOS won't support it.)") + sys.exit(1) - # provide upgrade path - handle_compat_warning(device) + # provide upgrade path + handle_compat_warning(device) - # check for vfat partition - handle_vfat(device) + # check for vfat partition + handle_vfat(device) - # main operation (like installing files) - for iso in isos: - install(iso, device) + # main operation (like installing files) + for iso in isos: + install(iso, device) - # install mbr - is_superfloppy = not device[-1:].isdigit() - if is_superfloppy: - logging.info("Detected superfloppy format - not installing MBR") + # install mbr + is_superfloppy = not device[-1:].isdigit() + if is_superfloppy: + logging.info("Detected superfloppy format - not installing MBR") - if not options.skipmbr and not os.path.isdir(device) and not is_superfloppy: - handle_mbr(device) + if not options.skipmbr and not os.path.isdir(device) and not is_superfloppy: + handle_mbr(device) - handle_bootloader(device) + handle_bootloader(device) - logging.info("Note: grml flavour %s was installed as the default booting system.", GRML_DEFAULT) + logging.info("Note: grml flavour %s was installed as the default booting system.", GRML_DEFAULT) - for flavour in GRML_FLAVOURS: - logging.info("Note: you can boot flavour %s using '%s' on the commandline.", flavour, flavour) + for flavour in GRML_FLAVOURS: + logging.info("Note: you can boot flavour %s using '%s' on the commandline.", flavour, flavour) - # finally be politely :) - logging.info("Finished execution of grml2usb (%s). Have fun with your grml system.", PROG_VERSION) + # finally be politely :) + logging.info("Finished execution of grml2usb (%s). Have fun with your grml system.", PROG_VERSION) + + except Exception, error: + logging.critical("Fatal: %s", str(error)) + sys.exit(1) if __name__ == "__main__":