From 411daf1e3e9fcbb9c4e4588a9fbe92513efb1ed1 Mon Sep 17 00:00:00 2001 From: Lukas Prokop Date: Wed, 19 Feb 2014 23:04:15 +0100 Subject: [PATCH] Silence errors the right way. Catch exceptions per operation (for-loop) per value (iterator). --- grml2usb | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/grml2usb b/grml2usb index 504b141..92c2cbf 100755 --- a/grml2usb +++ b/grml2usb @@ -166,14 +166,17 @@ def cleanup(): proc = subprocess.Popen(["sync"]) proc.wait() - try: - for device in MOUNTED: + for device in MOUNTED: + try: unmount(device, "") - for tmpfile in TMPFILES: + except RuntimeError: + logging.debug('RuntimeError while umount %s, ignoring' % device) + for tmpfile in TMPFILES: + try: os.unlink(tmpfile) - # ignore: RuntimeError: Set changed size during iteration - except RuntimeError: - logging.debug('caught exception RuntimeError, ignoring') + except RuntimeError: + msg = 'RuntimeError while removing temporary %s, ignoring' + logging.debug(msg % tmpfile) def register_tmpfile(path): -- 2.1.4