From 1eda797fd6bb47eb180d4a1d8e684aa55bff5911 Mon Sep 17 00:00:00 2001
From: Benjamin Drung <benjamin.drung@profitbricks.com>
Date: Wed, 25 Apr 2018 16:10:31 +0200
Subject: [PATCH] Double quote to prevent globbing and word splitting

shellcheck complained about missing double quotes in
`components/9990-networking.sh`.
---
 components/9990-networking.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/components/9990-networking.sh b/components/9990-networking.sh
index 2927107..9cc3674 100755
--- a/components/9990-networking.sh
+++ b/components/9990-networking.sh
@@ -84,7 +84,7 @@ do_netsetup ()
 		fi
 
 		# split args of ethdevice=eth0,eth1 into "eth0 eth1"
-		for device in $(echo $ETHDEVICE | sed 's/,/ /g')
+		for device in $(echo "$ETHDEVICE" | sed 's/,/ /g')
 		do
 			devlist="$devlist $device"
 		done
@@ -92,12 +92,12 @@ do_netsetup ()
 		for dev in $devlist
 		do
 			echo "Executing ipconfig -t $ETHDEV_TIMEOUT $dev"
-			ipconfig -t "$ETHDEV_TIMEOUT" $dev | tee -a /netboot.config
+			ipconfig -t "$ETHDEV_TIMEOUT" "$dev" | tee -a /netboot.config
 
 			# if configuration of device worked we should have an assigned
 			# IP address, if so let's use the device as $DEVICE for later usage.
 			# simple and primitive approach which seems to work fine
-			if ifconfig $dev | grep -q -E 'inet.*addr:|inet [0-9][0-9]*.[0-9][0-9]*.[0-9][0-9]*.[0-9][0-9]*'
+			if ifconfig "$dev" | grep -q -E 'inet.*addr:|inet [0-9][0-9]*.[0-9][0-9]*.[0-9][0-9]*.[0-9][0-9]*'
 			then
 				export DEVICE="$dev"
 				break
@@ -105,9 +105,9 @@ do_netsetup ()
 		done
 	else
 		for interface in ${DEVICE}; do
-			ipconfig -t "$ETHDEV_TIMEOUT" ${interface} | tee /netboot-${interface}.config
+			ipconfig -t "$ETHDEV_TIMEOUT" "${interface}" | tee "/netboot-${interface}.config"
 
-			[ -e /run/net-${interface}.conf ] && . /run/net-${interface}.conf
+			[ -e "/run/net-${interface}.conf" ] && . "/run/net-${interface}.conf"
 
 			if [ "$IPV4ADDR" != "0.0.0.0" ]
 			then
@@ -121,14 +121,14 @@ do_netsetup ()
 		# source relevant ipconfig output
 		OLDHOSTNAME=${HOSTNAME}
 
-		[ -e /run/net-${interface}.conf ] && . /run/net-${interface}.conf
+		[ -e "/run/net-${interface}.conf" ] && . "/run/net-${interface}.conf"
 
-		[ -z ${HOSTNAME} ] && HOSTNAME=${OLDHOSTNAME}
+		[ -z "${HOSTNAME}" ] && HOSTNAME="${OLDHOSTNAME}"
 		export HOSTNAME
 
 		if [ -n "${interface}" ]
 		then
-			HWADDR="$(cat /sys/class/net/${interface}/address)"
+			HWADDR="$(cat "/sys/class/net/${interface}/address")"
 		fi
 
 		# Only create /etc/hosts if FQDN is known (to let 'hostname -f' query
-- 
2.1.4