summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
8aed9f5)
We pass the requested --grub … device argument to the GRUB package
configuration, like:
| # debconf-show grub-pc | grep grub-pc/install_devices:
| * grub-pc/install_devices: /dev/sda
But the GRUB package tries to use /dev/disk/by-id/... for
install_devices setting (since 2010 and Debian/squeeze AFAICS), as can
be observed by reconfiguring the GRUB package (which then automatically
converts the /dev/sdX to the proper /dev/disk/by-id/... device when
being asked in the debconf prompt):
| # dpkg-reconfigure grub-pc
| grub-pc: Running grub-install ...
| [...]
| # debconf-show grub-pc | grep grub-pc/install_devices:
| * grub-pc/install_devices: /dev/disk/by-id/ata-VBOX_HARDDISK_VBf4f4391c-
6316fa69
The available_ids() and device_to_id() helper functions are based on
code by Colin Watson <cjwatson@debian.org> in GRUB's postinst script
of the Debian package, see git commits
4830efd9e +
ce2a43c85 at
https://salsa.debian.org/grub-team/grub.git.
Closes: https://github.com/grml/grml-debootstrap/issues/206
}
# grub configuration/installation {{{
}
# grub configuration/installation {{{
+
+# helper function to get relevant /dev/disk/by-id/* entries,
+# based on GRUB's postinst script
+available_ids() {
+ local path ids
+
+ [ -d /dev/disk/by-id ] || return
+ ids="$(
+ for path in /dev/disk/by-id/*; do
+ [ -e "${path}" ] || continue
+ printf '%s %s\n' "${path}" "$(readlink -f "${path}")"
+ done | sort -k2 -s -u | cut -d' ' -f1
+ )"
+ echo "${ids}"
+}
+
+# helper function to report corresponding /dev/disk/by-id/… for a given device name,
+# based on GRUB's postinst script
+device_to_id() {
+ local id
+
+ for id in $(available_ids); do
+ if [ "$(readlink -f "${id}")" = "$(readlink -f "$1")" ]; then
+ echo "${id}"
+ return 0
+ fi
+ done
+
+ # Fall back to the plain device name if there's no by-id link for it.
+ if [ -e "$1" ]; then
+ echo "$1"
+ return 0
+ fi
+ return 1
+}
+
grub_install() {
if [ -z "$GRUB" ] ; then
grub_install() {
if [ -z "$GRUB" ] ; then
# make sure this is pre-defined so we have sane settings for automated
# upgrades, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=711019
# make sure this is pre-defined so we have sane settings for automated
# upgrades, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=711019
+ local grub_device
+ grub_device=$(device_to_id "${GRUB}")
+ if [ -z "${grub_device:-}" ] ; then
+ echo "Warning: Could not identify /dev/disk/by-id/... for '${GRUB}', falling back to '${GRUB}'"
+ grub_device="${GRUB}"
+ fi
+
echo "Setting ${GRUB_PACKAGE} debconf configuration for install device to $GRUB"
echo "Setting ${GRUB_PACKAGE} debconf configuration for install device to $GRUB"
- echo "${GRUB_PACKAGE} ${GRUB_PACKAGE}/install_devices multiselect $GRUB" | debconf-set-selections
+ echo "${GRUB_PACKAGE} ${GRUB_PACKAGE}/install_devices multiselect ${grub_device}" | debconf-set-selections
if ! dpkg --list ${GRUB_PACKAGE} 2>/dev/null | grep -q '^ii' ; then
echo "Notice: grub option set but no ${GRUB_PACKAGE} package, installing it therefore."
if ! dpkg --list ${GRUB_PACKAGE} 2>/dev/null | grep -q '^ii' ; then
echo "Notice: grub option set but no ${GRUB_PACKAGE} package, installing it therefore."