last_exit_code="$?"
last_bash_command="$BASH_COMMAND"
if [ "$REPORT_TRAP_ERR" = "yes" ]; then
- echo "Unexpected non-zero exit code $last_exit_code in $BASH_SOURCE at line $BASH_LINENO detected!
+ echo "Unexpected non-zero exit code $last_exit_code in ${BASH_SOURCE[*]} at line ${BASH_LINENO[*]} detected!
last bash command: $last_bash_command"
fi
if [ ! "$FAIL_TRAP_ERR" = "yes" ]; then
[ -n "$POST_SCRIPTS" ] || POST_SCRIPTS='yes'
[ -n "$PRE_SCRIPTS" ] || PRE_SCRIPTS='yes'
[ -n "$RECONFIGURE" ] || RECONFIGURE='console-data'
-[ -n "$RELEASE" ] || RELEASE='jessie'
+[ -n "$RELEASE" ] || RELEASE='stretch'
[ -n "$RM_APTCACHE" ] || RM_APTCACHE='yes'
[ -n "$SCRIPTS" ] || SCRIPTS='no' # deprecated, replaced by POST_SCRIPTS
[ -n "$SECURE" ] || SECURE='yes'
-m, --mirror <URL> Mirror which should be used for apt-get/aptitude.
-i, --iso <mnt> Mountpoint where a Debian ISO is mounted to, for use
instead of fetching packages from a mirror.
- -r, --release <name> Release of new Debian system (default: jessie).
+ -r, --release <name> Release of new Debian system (default: stretch).
-t, --target <target> Target partition (/dev/...) or directory where the
system should be installed to.
-p, --mntpoint <mnt> Mountpoint used for mounting the target system,
einfon() {
[ "${RC_ENDCOL}" != "yes" ] && [ "${LAST_E_CMD}" = "ebegin" ] && echo
- printf " ${GOOD}*${NORMAL} $*"
+ printf " %s*%s $*" "${GOOD}" "${NORMAL}"
LAST_E_CMD=einfon
return 0
}
ewarn() {
- printf " ${WARN}*${NORMAL} $*\n"
+ printf " %s*%s $*\n" "${WARN}" "${NORMAL}"
return 0
}
eerror() {
[ "${RC_ENDCOL}" != "yes" ] && [ "${LAST_E_CMD}" = "ebegin" ] && echo
- printf " ${BAD}*${NORMAL} $*\n" >&2
+ printf " %s*%s $*\n" "${BAD}" "${NORMAL}" >&2
LAST_E_CMD=eerror
return 0
}
local retval="${1:-0}"
shift
if [ "$retval" -gt 0 ]; then
- printf " ${BAD}-> Failed (rc=${retval})${NORMAL}\n"
+ printf " %s-> Failed (rc=%s)%s\n" "${BAD}" "${retval}" "${NORMAL}"
fi
return "$retval"
}
# source main configuration file {{{
if [ -r /etc/debootstrap/config ] ; then
+ # shellcheck disable=SC1091
. /etc/debootstrap/config
fi
# }}}
# source external command line parameter-processing script
self_dir="$(dirname "$(which "$0")")"
if [ -r "${self_dir}"/cmdlineopts.clp ] ; then
- . "${self_dir}"/cmdlineopts.clp
+ # shellcheck source=cmdlineopts.clp
+ . "${self_dir}"/cmdlineopts.clp
elif [ -r /usr/share/grml-debootstrap/functions/cmdlineopts.clp ] ; then
- . /usr/share/grml-debootstrap/functions/cmdlineopts.clp
+ # shellcheck source=cmdlineopts.clp
+ . /usr/share/grml-debootstrap/functions/cmdlineopts.clp
else
- eerror "Error: cmdline function file not found, exiting."
- eend 1
- bailout 1
+ eerror "Error: cmdline function file not found, exiting."
+ eend 1
+ bailout 1
fi
# == business-logic of command line parameter-processing
if ! [ -r "$CONFFILES/config" ] ; then
eerror "Error: config file $CONFFILES/config not found."; eend 1; bailout 1
fi
+ # shellcheck disable=SC1091 source=config
if ! . "$CONFFILES/config" ; then
eerror "Error reading config file $CONFFILES/config" ; eend 1 ; bailout 1
fi
# source specified configuration file {{{
if [ -n "$CONFIGFILE" ] ; then
- einfo "Reading specified config file $CONFIGFILE."
- if ! . "$CONFIGFILE" ; then
- eerror "Error reading config file $CONFIGFILE" ; eend 1 ; bailout 1
- fi
+ einfo "Reading specified config file $CONFIGFILE."
+ # shellcheck disable=SC1091 source=config
+ if ! . "$CONFIGFILE" ; then
+ eerror "Error reading config file $CONFIGFILE" ; eend 1 ; bailout 1
+ fi
fi
# }}}
-# backwards compability checks {{{
+# backwards compatibility checks {{{
if [ -n "$GROOT" ] ; then
eerror "Error: you seem to have \$GROOT configured."
eerror "This variable is no longer supported, please visit the"
unset fs
done)
+ # shellcheck disable=SC2086
TARGET=$(dialog --title "$PN" --single-quoted --stdout \
--menu "Please select the target partition:" 0 0 0 \
$PARTITION_LIST)
found=1
break
done
- [ -n "$found" ] && MBRDISK=$(echo "${device}" |sed -e 's/-part[0-9][0-9]*$//')
+ # shellcheck disable=SC2001
+ [ -n "$found" ] && MBRDISK=$(echo "${device}" | sed -e 's/-part[0-9][0-9]*$//')
if [ -e "$MBRDISK" ]; then
MBRDISK=$(readlink -f "$MBRDISK")
else
# fall back to old behaviour
+ # shellcheck disable=SC2001
MBRDISK=$(echo "${TARGET}" | sed -e 's/[0-9][0-9]*$//')
fi
OIFS="$IFS"; IFS=:
+ # shellcheck disable=SC2086
GETMBR=$(dialog --stdout --title "$PN" --default-item mbr \
--menu "Where do you want to install the bootmanager grub?" 0 0 0 \
mbr "install bootmanager into $MBRPART" \
# ask for Debian release {{{
prompt_for_release()
{
- [ -n "$RELEASE" ] && DEFAULT_RELEASE="$RELEASE" || DEFAULT_RELEASE='jessie'
+ [ -n "$RELEASE" ] && DEFAULT_RELEASE="$RELEASE" || DEFAULT_RELEASE='stretch'
RELEASE="$(dialog --stdout --title "${PN}" --default-item $DEFAULT_RELEASE --menu \
"Please enter the Debian release you would like to use for installation:" \
0 50 5 \
echo "/dev/md$i /dev/md$i"
done)
+# shellcheck disable=SC2086
TARGET=$(dialog --stdout --title "$PN" --default-item /dev/md0 \
--menu "Which device do you want to use for ${RAIDLEVEL}?
echo "$i $(blkid -s TYPE -o value "$i" 2>/dev/null || echo '[no_filesystem_yet]') off"
done)
+# shellcheck disable=SC2086
dialog --title "$PN" --separate-output \
--checklist "Please select the partitions you would like to use for your $RAIDLEVEL on ${TARGET}:" 0 0 0 \
$PARTITION_LIST 2>"$TMPFILE"
SELECTED_PARTITIONS="$(cat "$TMPFILE")"
NUM_PARTITIONS=0
-for i in $(cat "$TMPFILE") ; do
- NUM_PARTITIONS=$(( NUM_PARTITIONS + 1 ))
-done
+while IFS= read -r i; do
+ NUM_PARTITIONS=$(( NUM_PARTITIONS + 1 ))
+done < "$TMPFILE"
# force metadata version 0.90 for lenny so old grub can boot from this array.
METADATA_VERSION=""
fi
ERRORFILE=$(mktemp)
+# shellcheck disable=SC2086
yes | mdadm --create "${TARGET}" --level="${RAIDLEVEL}" \
--raid-devices="${NUM_PARTITIONS}" ${METADATA_VERSION} ${SELECTED_PARTITIONS} >/dev/null 2>$ERRORFILE
RC=$?
if fsck.vfat -bn "$EFI" >/dev/null; then
einfo "EFI partition $EFI seems to have a FAT filesystem, not modifying." ; eend 0
else
- einfo "EFI partition $EFI doesn't seem to be formated, creating filesystem."
+ einfo "EFI partition $EFI doesn't seem to be formatted, creating filesystem."
mkfs.fat -F32 -n "EFI System Partition" "$EFI"
RC=$?
if [ $RC -eq 0 ] ; then
return 0
fi
- if modprobe efivars ; then
+ if modprobe efivars &>/dev/null ; then
einfo "EFI support enabled now." ; eend 0
return 0
fi
[ -n "$CONFFILES" ] && echo " Config files: $CONFFILES"
if [ -n "$VIRTUAL" ] ; then
echo " Deploying as Virtual Machine."
- if [ -n "$VMSIZE" -a -n "$VMFILE" ]; then
+ if [ -n "$VMSIZE" ] && [ -n "$VMFILE" ]; then
echo " Using Virtual Disk file with size of ${VMSIZE}."
fi
fi
- if [ ! -t 0 -a -z "$ROOTPASSWORD" -a -z "$NOPASSWORD" ] ; then
+ if [ ! -t 0 ] && [ -z "$ROOTPASSWORD" ] && [ -z "$NOPASSWORD" ] ; then
echo
echo " You do not have a TTY allocated, your password will be shown in"
echo " plaintext on the terminal! If you are using SSH, try its -t option!"
else
echo
einfon "Is this ok for you? [y/N] "
- read a
- if ! [ "$a" = 'y' -o "$a" = 'Y' ] ; then
+ read -r a
+ if ! [ "$a" = 'y' ] || [ "$a" = 'Y' ] ; then
eerror "Exiting as requested." ; eend 1
bailout 1
fi
}
# run interactive mode if we didn't get the according configuration yet
-if [ -z "$TARGET" -o -n "$INTERACTIVE" ] ; then
+if [ -z "$TARGET" ] || [ -n "$INTERACTIVE" ] ; then
# only target might be unset, so make sure the INTERACTIVE flag is set as well
INTERACTIVE=1
interactive_mode
einfo "Enabling force option (-F) for mkfs.ext* tool as requested via --force switch."
MKFS_OPTS="$MKFS_OPTS -F"
eend 0
+
+ ;;
+ esac
+ fi
+
+ # starting with e2fsprogs 1.43~WIP.2015.05.18-1 mkfs.ext4 enables the metadata_csum feature
+ # by default, which requires a recent version of tune2fs on the target system then,
+ # so disable this feature for older Debian releases where it's known to be unsupported
+ if [ -n "$MKFS" ] && [ "$MKFS" = "mkfs.ext4" ] ; then
+ case "$RELEASE" in
+ lenny|squeeze|wheezy|jessie)
+ # assume a more recent version if we can't identify the version via dpkg-query
+ local e2fsprogs_version
+ e2fsprogs_version="$(dpkg-query --show --showformat='${Version}' e2fsprogs 2>/dev/null || echo 1.44)"
+ if [ -n "$e2fsprogs_version" ] && dpkg --compare-versions "$e2fsprogs_version" ge '1.43~WIP.2015.05.18-1' ; then
+ einfo "Disabling metadata_csum feature for $MKFS as $RELEASE doesn't support it."
+ MKFS_OPTS="$MKFS_OPTS -O ^metadata_csum"
+ eend 0
+ fi
;;
esac
fi
if [ -n "$MKFS" ] ; then
einfo "Running $MKFS $MKFS_OPTS on $TARGET"
+ # shellcheck disable=SC2086
"$MKFS" $MKFS_OPTS "$TARGET" ; RC=$?
if [ "$FIXED_DISK_IDENTIFIERS" = "yes" ] ; then
# if we deploy to /dev/sdX# then let's see if /dev/sdX exists
local main_device="${TARGET%%[0-9]*}"
# sanity check to not try to e.g. access /dev/loop if we get /dev/loop0
- if [ -f "/sys/block/$(basename ${main_device})/$(basename ${TARGET})/dev" ] ; then
+ if [ -f "/sys/block/$(basename "${main_device}")/$(basename "${TARGET}")/dev" ] ; then
blockdev --rereadpt "$main_device"
else
einfo "No underlying block device for $TARGET identified, skipping blockdev --rereadpt."
# race conditions :-/
sleep 2
- eval "$(blkid -o udev "$TARGET" 2>/dev/null)"
- [ -n "$ID_FS_UUID" ] && TARGET_UUID="$ID_FS_UUID" || TARGET_UUID=""
-
eend $RC
fi
}
# }}}
+identify_target_uuid() {
+ local device="$1"
+
+ if ! [ -b "$device" ] ; then
+ return 1
+ fi
+
+ eval "$(blkid -o udev "$1" 2>/dev/null)"
+
+ if [ -n "$ID_FS_UUID" ] ; then
+ echo "$ID_FS_UUID"
+ else
+ return 1
+ fi
+}
+
+mountpoint_to_blockdevice() {
+ TARGET_UUID=''
+
+ TARGET_UUID=$(identify_target_uuid "$TARGET" 2>/dev/null || true)
+ if [ -n "$TARGET_UUID" ] ; then
+ einfo "Identified UUID $TARGET_UUID for $TARGET"
+ return 0
+ fi
+
+ # $TARGET might be a mountpoint and not a blockdevice, search for according entry
+ for file in /sys/block/*/*/dev ; do
+ if grep -q "^$(mountpoint -d "${TARGET}")$" "$file" ; then
+ local dev
+ dev="${file%/dev}"
+ dev="/dev/${dev##*/}"
+ TARGET_UUID=$(identify_target_uuid "$dev" 2>/dev/null || true)
+
+ if [ -n "$TARGET_UUID" ] ; then
+ einfo "Identified UUID $TARGET_UUID for $TARGET (via $file)"
+ return 0
+ fi
+ fi
+ done
+}
+
# modify filesystem settings {{{
tunefs() {
if [ -n "$TUNE2FS" ] && echo "$MKFS" | grep -q "mkfs.ext" ; then
return 0 # be quiet by intention
fi
- if [ -b "$TARGET" -a -n "$VMFILE" ] ; then
+ if [ -b "$TARGET" ] && [ -n "$VMFILE" ] ; then
eerror "Error: specified virtual disk target ($TARGET) is an existing block device."
eend 1
bailout 1
fi
- if [ ! -b "$TARGET" -a -z "$VMFILE" ] ; then
+ if [ ! -b "$TARGET" ] && [ -z "$VMFILE" ] ; then
eerror "Error: specified virtual disk target ($TARGET) does not exist yet."
eend 1
bailout 1
fi
fi
- DEVINFO=$(kpartx -asv "$TARGET") # 'add map loop1p1 (253:0): 0 6289408 linear /dev/loop1 2048'
+ DEVINFO=$(kpartx -asv "$TARGET") # e.g. 'add map loop0p1 (254:5): 0 20477 linear 7:0 3'
if [ -z "${DEVINFO}" ] ; then
eerror "Error setting up loopback device." ; eend 1
bailout 1
fi
# hopefully this always works as expected
- LOOP=$(echo "${DEVINFO}" | sed 's/.* linear //; s/ [[:digit:]]*//') # 'loop1'
- LOOP_PART="$(echo "${DEVINFO##add map }" | sed 's/ .*//')" # 'loop1p1'
+ LOOP_PART="${DEVINFO##add map }" # 'loop0p1 (254:5): 0 20477 linear 7:0 3'
+ LOOP_PART="${LOOP_PART// */}" # 'loop0p1'
export TARGET="/dev/mapper/$LOOP_PART" # '/dev/mapper/loop1p1'
if [ -z "$TARGET" ] ; then
mount -t proc none "${MNTPOINT}"/proc
mount -t sysfs none "${MNTPOINT}"/sys
- mount --bind /dev "${MNTPOINT}"/dev
- mount --bind /dev/pts "${MNTPOINT}"/dev/pts
+ mount -t devtmpfs udev "${MNTPOINT}"/dev
+ mount -t devpts devpts "${MNTPOINT}"/dev/pts
# Has chroot-script installed GRUB to MBR using grub-install (successfully), already?
# chroot-script skips installation for unset ${GRUB}
if ! chroot "${MNTPOINT}" dpkg --list grub-pc 2>/dev/null | grep -q '^ii' ; then
echo "Notice: grub-pc package not present yet, installing it therefore."
+ # shellcheck disable=SC2086
DEBIAN_FRONTEND=$DEBIAN_FRONTEND chroot "$MNTPOINT" apt-get -y install $DPKG_OPTIONS grub-pc
fi
;;
esac
- case "$RELEASE" in
- lenny|squeeze|wheezy)
- if grep -q '^GRUB_DISABLE_LINUX_UUID=.*true' "${MNTPOINT}"/etc/default/grub 2>/dev/null ; then
- ewarn "GRUB_DISABLE_LINUX_UUID is set to true in /etc/default/grub, not adjusting root= in grub.cfg."
- ewarn "Please note that your system might NOT be able to properly boot."
- else
- einfo "Adjusting grub.cfg for successful boot sequence."
- sed -i "s;root=[^ ]\+;root=UUID=$TARGET_UUID;" "${MNTPOINT}"/boot/grub/grub.cfg
- fi
- ;;
- esac
+ if grep -q '^GRUB_DISABLE_LINUX_UUID=.*true' "${MNTPOINT}"/etc/default/grub 2>/dev/null ; then
+ ewarn "GRUB_DISABLE_LINUX_UUID is set to true in /etc/default/grub, not adjusting root= in grub.cfg."
+ ewarn "Please note that your system might NOT be able to properly boot."
+ else
+ einfo "Adjusting grub.cfg for successful boot sequence."
+ sed -i "s;root=[^ ]\+;root=UUID=$TARGET_UUID;" "${MNTPOINT}"/boot/grub/grub.cfg
+ fi
umount "${MNTPOINT}"/proc
umount "${MNTPOINT}"/sys
if [ -n "$ISO" ] ; then
einfo "Running $DEBOOTSTRAP $DEBOOTSTRAP_OPT for release ${RELEASE}${ARCHINFO} using ${ISO}"
einfo "Executing: $DEBOOTSTRAP $ARCHCMD $KEYRING $DEBOOTSTRAP_OPT $RELEASE $MNTPOINT $ISO"
+ # shellcheck disable=SC2086
"$DEBOOTSTRAP" $ARCHCMD $KEYRING $DEBOOTSTRAP_OPT "$RELEASE" "$MNTPOINT" "$ISO"
RC=$?
else
einfo "Running $DEBOOTSTRAP $DEBOOTSTRAP_OPT for release ${RELEASE}${ARCHINFO} using ${MIRROR}"
einfo "Executing: $DEBOOTSTRAP $ARCHCMD $KEYRING $DEBOOTSTRAP_OPT $RELEASE $MNTPOINT $MIRROR"
+ # shellcheck disable=SC2086
"$DEBOOTSTRAP" $ARCHCMD $KEYRING $DEBOOTSTRAP_OPT "$RELEASE" "$MNTPOINT" "$MIRROR"
RC=$?
fi
# make sure we can access network [relevant for cdebootstrap]
[ -f "${MNTPOINT}"/etc/resolv.conf ] || cp $VERBOSE /etc/resolv.conf "${MNTPOINT}"/etc/resolv.conf
- # provide system's /etc/hosts to the target:
- if ! [ -f "$MNTPOINT/etc/hosts" ] ; then
- cp $VERBOSE /etc/hosts "${MNTPOINT}"/etc/hosts
- fi
-
# setup default locales
[ -n "$LOCALES" ] && cp $VERBOSE "${CONFFILES}"/locale.gen "${MNTPOINT}"/etc/locale.gen
fi
# install config file providing some example entries
- if [ -r /etc/network/interfaces.examples -a ! -r "$MNTPOINT/etc/network/interfaces.examples" ] ; then
+ if [ -r /etc/network/interfaces.examples ] && [ ! -r "$MNTPOINT/etc/network/interfaces.examples" ] ; then
cp /etc/network/interfaces.examples "$MNTPOINT/etc/network/interfaces.examples"
fi
# execute all scripts in /etc/debootstrap/post-scripts/ {{{
execute_post_scripts() {
- # make sure we have $MNTPOINT available for our scripts
+ # make sure we have $MNTPOINT and HOSTNAME available for our scripts
export MNTPOINT
+ export TARGET_HOSTNAME=$HOSTNAME
if [ -d "$_opt_scripts" ] || [ "$SCRIPTS" = 'yes' ] ; then
# legacy support for /etc/debootstrap/scripts/
eend 1
else
einfo "Executing chroot-script now"
- mount --bind /dev "$MNTPOINT"/dev
- mount --bind /dev/pts "$MNTPOINT"/dev/pts
+ mount -t devtmpfs udev "${MNTPOINT}"/dev
+ mount -t devpts devpts "${MNTPOINT}"/dev/pts
if [ "$DEBUG" = "true" ] ; then
chroot "$MNTPOINT" /bin/bash -x /bin/chroot-script ; RC=$?
else
# }}}
# now execute all the functions {{{
-for i in format_efi_partition prepare_vm mkfs tunefs mount_target debootstrap_system \
+for i in format_efi_partition prepare_vm mkfs tunefs \
+ mount_target mountpoint_to_blockdevice debootstrap_system \
preparechroot execute_pre_scripts chrootscript execute_post_scripts \
remove_configs umount_chroot finalize_vm fscktool ; do
if stage "${i}" ; then
projects / grml-debootstrap.git / blobdiff