resolv.conf handling: resolve symlink inside chroot + drop resolvconf from 96-apt...

[grml-live.git] / etc / grml / fai / config / hooks / instsoft.GRMLBASE

diff --git a/etc/grml/fai/config/hooks/instsoft.GRMLBASE b/etc/grml/fai/config/hooks/instsoft.GRMLBASE
index 9d37e12..51a0e77 100755 (executable)
--- a/etc/grml/fai/config/hooks/instsoft.GRMLBASE
+++ b/etc/grml/fai/config/hooks/instsoft.GRMLBASE
@@ -21,28 +21,31 @@ if [ "$FAI_ACTION" = "softupdate" ] ; then
    echo "Action $FAI_ACTION of FAI (hooks/instsoft.GRMLBASE) via grml-live running"
 
    if [ -r /etc/resolv.conf ] ; then
-     if [ -d $target/etc/resolvconf/run ] ; then # resolvconf without /run
-       # sanity check to avoid "input file is output file",
-       # see http://bts.grml.org/grml/issue984
-       if ! [ -L $target/etc/resolvconf/run/resolv.conf ] ; then
-         cat /etc/resolv.conf >> $target/etc/resolvconf/run/resolv.conf
-       else
-         echo "Error: /etc/resolvconf/run/resolv.conf in chroot should not be a symlink." >&2
-         echo "       Looks like something is wrong, please fix manually." >&2
-         exit 1
-       fi
-     elif [ -L $target/etc/resolvconf/run ] ; then # resolvconf with /run
-       # /etc/resolvconf/run symlinks to /run/resolvconf
-       mkdir -p $target/run/resolvconf
-       cat /etc/resolv.conf >> $target/run/resolvconf/resolv.conf
-     else # no resolvconf installed in chroot
-       if ! [ -L $target/etc/resolv.conf ] ; then
-         cat /etc/resolv.conf >> $target/etc/resolv.conf
-       else
-         echo "Error: /etc/resolv.conf in chroot should not be a symlink (resolvconf not installed)." >&2
-         exit 1
-       fi
-     fi
+     case "$(chroot $target readlink -f /etc/resolv.conf)" in
+       /run/*) # resolvconf with /run
+         mkdir -p $target/run/resolvconf
+         cat /etc/resolv.conf >> $target/run/resolvconf/resolv.conf
+         ;;
+       /lib/*) # resolvconf without /run
+         # sanity check to avoid "input file is output file",
+         # see http://bts.grml.org/grml/issue984
+         if ! [ -L $target/etc/resolvconf/run/resolv.conf ] ; then
+           cat /etc/resolv.conf >> $target/etc/resolvconf/run/resolv.conf
+         else
+           echo "Error: /etc/resolvconf/run/resolv.conf in chroot should not be a symlink." >&2
+           echo "       Looks like something is wrong, please fix manually." >&2
+           exit 1
+         fi
+         ;;
+       *) # no resolvconf
+         if ! [ -L $target/etc/resolv.conf ] ; then
+           cat /etc/resolv.conf >> $target/etc/resolv.conf
+         else
+           echo "Error: /etc/resolv.conf in chroot should not be a symlink (resolvconf not installed)." >&2
+           exit 1
+         fi
+         ;;
+     esac
    fi
 
    if [ -r $target/etc/policy-rc.d.conf ] ; then
@@ -60,15 +63,6 @@ if [ "$FAI_ACTION" = "softupdate" ] ; then
 //DPkg::Tools::Options::/usr/sbin/apt-listbugs::Version "2";
 EOF
 
-   # run it on our own, as updatebase is used at the wrong stage for our needs,
-   # see ${GRML_FAI_CONFIG}/hooks/updatebase.GRMLBASE
-   # the apt-get update might return an error if there's for example
-   # a hashsum mismatch on Debian mirror sources, we might want to continue
-   # but should warn the user
-   if ! $ROOTCMD apt-get update ; then
-      echo "Warning: there was an error executing apt-get update, continuing anyway."
-   fi
-
    # work around /etc/kernel/postinst.d/zz-update-grub failing
    # inside openvz environment, see #597084
    if ! $ROOTCMD dpkg-divert --list | grep -q '/usr/sbin/update-grub' ; then