From cdb4aa447297942b280ff7e91dd135c397a43db7 Mon Sep 17 00:00:00 2001 From: meisterluk Date: Sat, 4 May 2013 21:57:57 +0200 Subject: [PATCH] Fix FORMAT definition for logging module. Level does not specify that only messages of this level are printed out, but the minimum level. So a definition like this FORMAT = "Debug: %(asctime)-15s %(message)s" FORMAT = "%(asctime)-15s %(message)s" misleads the user into thinking that every message printed out is actually a debug message, which is not true. We now use "%(message)s" for everything except verbose mode which annotates the timestamp to the message. --- grml2usb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grml2usb b/grml2usb index d5a8675..6cb76c0 100755 --- a/grml2usb +++ b/grml2usb @@ -1645,14 +1645,13 @@ def handle_logging(): if options.verbose and options.quiet: parser.error("please use either verbose (--verbose) or quiet (--quiet) option") + FORMAT = "%(message)s" if options.verbose: - FORMAT = "Debug: %(asctime)-15s %(message)s" + FORMAT = "%(asctime)-15s %(message)s" logging.basicConfig(level=logging.DEBUG, format=FORMAT) elif options.quiet: - FORMAT = "Critical: %(message)s" logging.basicConfig(level=logging.CRITICAL, format=FORMAT) else: - FORMAT = "%(message)s" logging.basicConfig(level=logging.INFO, format=FORMAT) -- 2.1.4