# helper functions {{{
cleanup() {
if [ -n "$CHROOT_VARIABLES" ] ; then
- einfo "Removing ${CHROOT_VARIABLES}" ; rm "$CHROOT_VARIABLES" ; eend $?
+ einfo "Removing ${CHROOT_VARIABLES}" ; rm "$CHROOT_VARIABLES" || eend $?
fi
if [ -n "$STAGES" ] ; then
- einfo "Removing ${STAGES}" ; rmdir "$STAGES" ; eend $?
+ einfo "Removing ${STAGES}" ; rmdir "$STAGES" || eend $?
fi
if [ -n "$ARM_EFI_TARGET" ]; then
# Remove temporary mountpoint again
if echo "$MNTPOINT" | grep -q '/mnt/debootstrap\.' ; then
- rmdir "$MNTPOINT" 2>/dev/null
+ if [ -d "$MNTPOINT" ] ; then
+ rmdir "$MNTPOINT" || true
+ fi
fi
# make sure $TARGET is not mounted when exiting grml-debootstrap
fi
done
- [ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount -a >/dev/null 2>&1
+ [ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount -a >/dev/null 2>&1 || true
# ugly, but make sure we really don't leave anything (/proc /proc and
# /dev /dev are intended, trying to work around timing issues, see #657023)
for ARG in /run/udev /sys /proc /proc /dev/pts /dev/pts /dev /dev ; do
- [ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount $ARG >/dev/null 2>&1
- umount "$MNTPOINT"/$ARG >/dev/null 2>&1
+ [ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount $ARG >/dev/null 2>&1 || true
+ umount "$MNTPOINT"/$ARG >/dev/null 2>&1 || true
done
if [ -n "$ISODIR" ] ; then
- [ -d "$MNTPOINT/$ISODIR" ] && umount "$MNTPOINT/$ISODIR" >/dev/null 2>&1
+ [ -d "$MNTPOINT/$ISODIR" ] && umount "$MNTPOINT/$ISODIR" >/dev/null 2>&1 || true
fi
if [ -n "$DIRECTORY" ] ; then
# remove directory only if we used the default with process id inside the name
if echo "$MNTPOINT" | grep -q '/mnt/debootstrap\.' ; then
- einfo "Removing directory ${MNTPOINT}"
- rmdir "$MNTPOINT" || eend $?
+ if test -d "$MNTPOINT" ; then
+ einfo "Removing directory ${MNTPOINT}"
+ rmdir "$MNTPOINT" || eend $?
+ fi
fi
fi
fi
# we want to exit smoothly and clean:
bailout(){
+ eend "$1" || true
cleanup
# source main configuration file {{{
if [ -r /etc/debootstrap/config ] ; then
+ bash -n /etc/debootstrap/config
# shellcheck disable=SC1091
. /etc/debootstrap/config
fi
# cmdline handling {{{
CMDLINE_OPTS=mirror:,iso:,release:,target:,mntpoint:,debopt:,defaultinterfaces,interactive,nodebootstrap,nointerfaces,nokernel,nopackages,filesystem:,config:,confdir:,packages:,chroot-scripts:,scripts:,post-scripts:,pre-scripts:,debconf:,vm,vmfile,vmsize:,vmefi,keep_src_list,hostname:,password:,nopassword,grmlrepos,backportrepos,bootappend:,grub:,efi:,arch:,insecure,verbose,help,version,force,debug,contrib,non-free,remove-configs,sshcopyid,sshcopyauth
-_opt_temp=$(getopt --name grml-debootstrap -o +m:i:r:t:p:c:d:vhV --long \
- $CMDLINE_OPTS -- "$@")
-
-if [ $? != 0 ]; then
- eerror "Try 'grml-debootstrap --help' for more information."; eend 1; exit 1
+if ! _opt_temp=$(getopt --name grml-debootstrap -o +m:i:r:t:p:c:d:vhV --long \
+ $CMDLINE_OPTS -- "$@"); then
+ eerror "Try 'grml-debootstrap --help' for more information."
+ bailout 1
fi
eval set -- "$_opt_temp"
CONFFILES=$_opt_confdir
einfo "Using config files under $CONFFILES/."
if ! [ -r "$CONFFILES/config" ] ; then
- eerror "Error: config file $CONFFILES/config not found."; eend 1; bailout 1
+ eerror "Error: config file $CONFFILES/config not found."; bailout 1
fi
# shellcheck disable=SC1091 source=config
if ! . "$CONFFILES/config" ; then
- eerror "Error reading config file $CONFFILES/config" ; eend 1 ; bailout 1
+ eerror "Error reading config file $CONFFILES/config" ; bailout 1
fi
# restore the command line parameter value
CONFFILES=$_opt_confdir
if [ "$_opt_grub" ] && [ "$_opt_vmfile" ] ; then
eerror "The --grub option is incompatible with --vmfile, please drop it from your command line."
eerror "The --grub option is unneeded as GRUB will be installed automatically (unless GRUB_INSTALL='no')."
- eend 1
bailout 1
fi
if [ "${_opt_sshcopyid}" ] && [ "${_opt_sshcopyauth}" ] ; then
eerror "The --sshcopyid option is incompatible with --sshcopyauth, please drop either of them from your command line."
- eend 1
bailout 1
fi
if [ -n "$ISO" ] && [[ "$DEBOOTSTRAP" =~ mmdebstrap$ ]] ; then
eerror "The ISO option is incompatible with usage of mmdebstrap for bootstrapping."
eerror "Either drop the --iso ... option or use plain debootstrap instead."
- eend 1
bailout 1
fi
# source specified configuration file {{{
if [ -n "$CONFIGFILE" ] ; then
einfo "Reading specified config file $CONFIGFILE."
+ bash -n "$CONFIGFILE"
# shellcheck disable=SC1091 source=config
if ! . "$CONFIGFILE" ; then
- eerror "Error reading config file $CONFIGFILE" ; eend 1 ; bailout 1
+ eerror "Error reading config file $CONFIGFILE" ; bailout 1
fi
fi
# }}}
eerror "Error: you seem to have \$GROOT configured."
eerror "This variable is no longer supported, please visit the"
eerror "grml-debootstrap documentation for details."
- eend 1
bailout 1
fi
if echo "$GRUB" | grep -q '^hd' ; then
eerror "Error: this syntax for the grub configuration variable is no longer supported."
eerror "Please do not use hd... any longer but /dev/sdX instead."
- eend 1
bailout 1
fi
# }}}
dialog --title "$PN" --trim \
--msgbox "Sorry, no partitions found. Please configure your
harddisks (see /proc/partitions) using a tool like fdisk,
- cfdisk, gpart, gparted,..." 0 0
- bailout 1
+ cfdisk, gpart, gparted,..." 0 0 || bailout 1
fi
PARTITION_LIST=$(for i in $AVAILABLE_PARTITIONS ; do
# shellcheck disable=SC2086
TARGET=$(dialog --title "$PN" --single-quoted --stdout \
--menu "Please select the target partition:" 0 0 0 \
- $PARTITION_LIST)
- [ $? -eq 0 ] || bailout 1
+ $PARTITION_LIST) || bailout 1
}
# }}}
--menu "Where do you want to install the bootmanager grub?" 0 0 0 \
mbr "install bootmanager into $MBRPART" \
nowhere "do not install bootmanager at all" \
- ${ADDITIONAL_PARAMS})
- [ $? -eq 0 ] || bailout 3
+ ${ADDITIONAL_PARAMS}) || bailout 3
IFS="$OIFS"
case "$GETMBR" in
buster Debian/10 \
bullseye Debian/11 \
bookworm Debian/12 \
- sid Debian/unstable)"
- [ $? -eq 0 ] || bailout
+ sid Debian/unstable)" \
+ || bailout
}
# }}}
{
HOSTNAME="$(dialog --stdout --title "${PN}" --inputbox \
"Please enter the hostname you would like to use for installation:" \
- 0 0 "$HOSTNAME")"
- [ $? -eq 0 ] || bailout
+ 0 0 "$HOSTNAME")" || bailout
}
# }}}
ROOTPW2='PW2'
while [ "$ROOTPW1" != "$ROOTPW2" ]; do
ROOTPW1=$(dialog --insecure --stdout --title "${PN}" --passwordbox \
- "Please enter the password for the root account:" 10 60)
- [ $? -eq 0 ] || bailout
+ "Please enter the password for the root account:" 10 60) || bailout
ROOTPW2=$(dialog --insecure --stdout --title "${PN}" --passwordbox \
"Please enter the password for the root account again for \
- confirmation:" 10 60)
- [ $? -eq 0 ] || bailout
+ confirmation:" 10 60) || bailout
if [ "$ROOTPW1" != "$ROOTPW2" ]; then
dialog --stdout --title "${PN}" --ok-label \
net "install via network (downloading from mirror)" \
local "install from local directory/mirror"
)
- [ $? -eq 0 ] || bailout
if [ "$CHOOSE_MIRROR" = 'net' ] ; then
[ -n "$MIRROR" ] || MIRROR='http://deb.debian.org/debian'
MIRROR="$(dialog --stdout --title "${PN}" --inputbox \
"Please enter Debian mirror you would like to use for installing packages." \
- 0 0 $MIRROR)"
- [ $? -eq 0 ] || bailout
+ 0 0 $MIRROR)" || bailout
+
else # CHOOSE_MIRROR == local
[ -n "$ISO" ] || ISO='/mnt/mirror'
ISO="$(dialog --stdout --title "${PN}" --inputbox \
"Please enter directory name you would like to use for installing packages." \
- 0 0 $ISO)"
- [ $? -eq 0 ] || bailout
+ 0 0 $ISO)" || bailout
fi
}
# }}}
--menu "Which device do you want to use for ${RAIDLEVEL}?
Notice: activated devices will not be listed for security reasons. Anyway, please make sure the selected device is not in use already!" 0 0 0 \
-$MD_LIST)
-[ $? -eq 0 ] || bailout 20
+$MD_LIST) || bailout 20
AVAILABLE_PARTITIONS=$(LANG=C fdisk -l 2>/dev/null | \
sed 's/*//' | \
# shellcheck disable=SC2086
dialog --title "$PN" --separate-output \
--checklist "Please select the partitions you would like to use for your $RAIDLEVEL on ${TARGET}:" 0 0 0 \
- $PARTITION_LIST 2>"$TMPFILE"
-[ $? -eq 0 ] || bailout
+ $PARTITION_LIST 2>"$TMPFILE" || bailout
+
SELECTED_PARTITIONS="$(cat "$TMPFILE")"
NUM_PARTITIONS=0
RC=$?
if [ ! $RC -eq 0 ] ; then
eerror "Error while creating filesystem on ${EFI}."
- eend 1
bailout 1
fi
fi
Is this ok for you? Notice: selecting 'No' will exit ${PN}."
dialog --title "$PN" --no-collapse \
- --yesno "$INFOTEXT" 0 0
- [ $? -eq 0 ] || bailout 0
+ --yesno "$INFOTEXT" 0 0 || bailout 0
else # if not running automatic installation display configuration and prompt for execution:
einfo "$PN [${VERSION}] - Please recheck configuration before execution:"
einfon "Is this ok for you? [y/N] "
read -r a
if ! [ "$a" = 'y' ] || [ "$a" = 'Y' ] ; then
- eerror "Exiting as requested." ; eend 1
+ eerror "Exiting as requested."
bailout 1
fi
fi
if [ -z "${ARCH:-}" ] ; then
eerror 'Architecture neither set (environment variable ARCH), nor could be automatically identified (using dpkg).'
- eerror 'Consider setting the --arch ... option.' ; eend 1
+ eerror 'Consider setting the --arch ... option.'
bailout 1
fi
# }}}
CURRENT_ARCH="$(uname -m)"
if [ "$CURRENT_ARCH" != "x86_64" ] ; then
if [ "$ARCH" = "amd64" ] ; then
- eerror "It is not possible to build amd64 on $CURRENT_ARCH. Consider installing and booting the 'linux-image-amd64' kernel or using '--arch i386' instead." ; eend 1
+ eerror "It is not possible to build amd64 on $CURRENT_ARCH. Consider installing and booting the 'linux-image-amd64' kernel or using '--arch i386' instead."
bailout 1
fi
fi
# Support for generic release codenames is unavailable. {{{
if [ "$RELEASE" = "stable" ] || [ "$RELEASE" = "testing" ] ; then
eerror "Generic release codenames (stable, testing) are unsupported. \
-Please use specific codenames such as bullseye or bookworm." ; eend 1
+Please use specific codenames such as bullseye or bookworm."
bailout 1
fi
# }}}
SHORT_TARGET="${TARGET##*/}"
else
eerror "Please adjust $CONFFILES/config or..."
- eerror "... use the interactive version for configuration before running ${0}" ; eend 1
+ eerror "... use the interactive version for configuration before running ${0}"
bailout 1
fi
# }}}
if [ -r "$STAGES"/grml-debootstrap ] ; then
if grep -q 'done' "${STAGES}/grml-debootstrap" ; then
eerror "Error: grml-debootstrap has been executed already, won't continue therefore."
- eerror "If you want to re-execute grml-debootstrap just manually remove ${STAGES}" ; eend 1
+ eerror "If you want to re-execute grml-debootstrap just manually remove ${STAGES}"
fi
fi
# }}}
# $TARGET was not detected as block device, but we do not want to create target directory in /dev/
if [[ $TARGET == "/dev/"* ]]; then
eerror "Error: Will not create target directory $TARGET in /dev."
- eerror " Please check the partition(s) of the blockdevice."; eend 1
+ eerror " Please check the partition(s) of the blockdevice."
bailout 1
fi
set_target_directory
fi
if grep -q "$TARGET" /proc/mounts ; then
- eerror "$TARGET already mounted, exiting to avoid possible damage. (Manually unmount $TARGET)" ; eend 1
+ eerror "$TARGET already mounted, exiting to avoid possible damage. (Manually unmount $TARGET)"
bailout 1
fi
if [ "$FIXED_DISK_IDENTIFIERS" = "yes" ] ; then
if ! echo "$MKFS" | grep -q "mkfs.ext" ; then
eerror "Not changing disk uuid for $TARGET because $MKFS doesn't seem to match for ext{2,3,4} file system"
- eend 1
bailout 1
else
einfo "Changing disk uuid for $TARGET to fixed (non-random) value $DISK_IDENTIFIER using tune2fs"
if [ -b "$TARGET" ] && [ -n "$VMFILE" ] ; then
eerror "Error: specified virtual disk target ($TARGET) is an existing block device."
- eend 1
bailout 1
fi
if [ ! -b "$TARGET" ] && [ -z "$VMFILE" ] ; then
eerror "Error: specified virtual disk target ($TARGET) does not exist yet."
- eend 1
bailout 1
fi
# make sure loop module is present and a usable loop device exists
- modprobe -q loop
+ modprobe loop || true
if ! losetup -f >/dev/null 2>&1; then
- eerror "Error finding usable loop device" ; eend 1
+ eerror "Error finding usable loop device"
bailout 1
fi
# if dm-mod isn't available then kpartx will fail with
# "Is device-mapper driver missing from kernel? [...]"
- modprobe -q dm-mod
+ modprobe dm-mod || true
if ! grep -q 'device-mapper' /proc/misc >/dev/null 2>&1 ; then
- eerror "Device-mapper support missing in kernel." ; eend 1
+ eerror "Device-mapper support missing in kernel."
bailout 1
fi
DEVINFO=$(kpartx -asv "$TARGET") # e.g. 'add map loop0p1 (254:5): 0 20477 linear 7:0 3' - will be multi-line for arm64
if [ -z "${DEVINFO}" ] ; then
- eerror "Error setting up loopback device." ; eend 1
+ eerror "Error setting up loopback device."
bailout 1
fi
export TARGET="/dev/mapper/$LOOP_PART" # '/dev/mapper/loop0p1'
if [ -z "$TARGET" ] ; then
- eerror "Error: target could not be set to according /dev/mapper/* device." ; eend 1
+ eerror "Error: target could not be set to according /dev/mapper/* device."
bailout 1
fi
}
fi
if ! mount "${TARGET}" "${MNTPOINT}" ; then
- eerror "Error: Mounting ${TARGET} failed, can not continue." ; eend 1
+ eerror "Error: Mounting ${TARGET} failed, can not continue."
bailout 1
fi
if [ -n "${ARM_EFI_TARGET}" ]; then
mkdir -p "${MNTPOINT}/boot/efi"
if ! mount "${ARM_EFI_TARGET}" "${MNTPOINT}/boot/efi" ; then
- eerror "Error: Mounting ${ARM_EFI_TARGET} failed, can not continue." ; eend 1
+ eerror "Error: Mounting ${ARM_EFI_TARGET} failed, can not continue."
bailout 1
fi
fi
mkdir -p "${MNTPOINT}/boot/grub"
if ! [ -d "${MNTPOINT}"/usr/lib/grub/i386-pc/ ] ; then
- eerror "Error: grub not installed inside Virtual Machine. Can not install bootloader." ; eend 1
+ eerror "Error: grub not installed inside Virtual Machine. Can not install bootloader."
bailout 1
fi
cp -a "${MNTPOINT}"/usr/lib/grub/i386-pc "${MNTPOINT}/boot/grub/"
chmod 0700 "${MNTPOINT}"/root/.ssh
if ! ssh-add -L >> "${MNTPOINT}"/root/.ssh/authorized_keys ; then
eerror "Error: executing 'ssh-add -L' failed."
- eend 1
bailout 1
fi
elif [ -f "$AUTHORIZED_KEYS_SOURCE" ]; then
chmod 0700 "$AUTHORIZED_KEYS_TARGET"
if ! cp "$AUTHORIZED_KEYS_SOURCE" "$AUTHORIZED_KEYS_TARGET" ; then
eerror "Error: copying '$AUTHORIZED_KEYS_SOURCE' to '$AUTHORIZED_KEYS_TARGET' failed"
- eend 1
bailout 1
fi
else
eerror "Error: Could not open a connection to your authentication agent or the agent has no identities."
- eend 1
bailout 1
fi
fi
if ! [ -f "${AUTHORIZED_KEYS_SOURCE}" ]; then
eerror "Error: could not read '${AUTHORIZED_KEYS_SOURCE}' for setting up SSH key login."
- eend 1
bailout 1
fi
chmod 0700 "${AUTHORIZED_KEYS_TARGET}"
if ! cp "${AUTHORIZED_KEYS_SOURCE}" "${AUTHORIZED_KEYS_TARGET}" ; then
eerror "Error: copying '${AUTHORIZED_KEYS_SOURCE}' to '${AUTHORIZED_KEYS_TARGET}' failed."
- eend 1
bailout 1
fi
fi
remove_configs umount_chroot grub_install umount_target fscktool ; do
if stage "${i}" ; then
"$i"
- if [ $? -eq 0 ]; then
- stage "${i}" 'done' && rm -f "${STAGES}/${i}"
- else
- bailout 2 "$i"
- fi
+ stage "${i}" 'done'
+ rm -f "${STAGES}/${i}"
fi
done