Don't quote $CIFSOPTS for mount.cifs (Closes: #703746).
authorAndrew Jeffery <andrewj@avalon.com.au>
Mon, 6 May 2013 12:12:35 +0000 (14:12 +0200)
committerDaniel Baumann <mail@daniel-baumann.ch>
Mon, 6 May 2013 12:13:03 +0000 (14:13 +0200)
Quoting $CIFSOPTS passed the literal string "-o user=root,password=" to
mount.cifs, killing mount.cifs with a SIGSEGV. Rather, -o should be
properly space delimited by passing $CIFSOPTS unquoted for options to be
parsed correctly.

scripts/boot/9990-mount-cifs.sh

index a8ef3f4..8dd1818 100755 (executable)
@@ -10,7 +10,7 @@ do_cifsmount ()
        then
                if [ -z "${NFSOPTS}" ]
                then
-                       CIFSOPTS="-ouser=root,password="
+                       CIFSOPTS="-o user=root,password="
                else
                        CIFSOPTS="-o ${NFSOPTS}"
                fi
@@ -18,7 +18,7 @@ do_cifsmount ()
                log_begin_msg "Trying mount.cifs ${NFSROOT} ${mountpoint} ${CIFSOPTS}"
                modprobe -q cifs
 
-               if mount.cifs "${NFSROOT}" "${mountpoint}" "${CIFSOPTS}"
+               if mount.cifs "${NFSROOT}" "${mountpoint}" ${CIFSOPTS}
                then
                        rc=0
                fi